Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from wee_alloc #187

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Migrate from wee_alloc #187

merged 9 commits into from
Sep 20, 2024
+83 −71

Conversation

alexlapa
Copy link
Contributor

@alexlapa alexlapa commented Sep 16, 2024 •
edited by tyranron
Loading

Synopsis

So wee_alloc has been unmaintained for 5 years and has some bugs (1, 2, 3) that probably will never get fixed.

Solution

Migrate to talc which seems to be mature and well maintained alternative.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::web Specific to WEB platform k::dependencies Pull requests that update a dependency file labels Sep 16, 2024
@alexlapa alexlapa self-assigned this Sep 16, 2024
@alexlapa
Copy link
Contributor Author

alexlapa commented Sep 18, 2024 •
edited by tyranron
Loading

FCM:

Migrate from `wee_alloc` allocator to `talc` on web (#187)

@alexlapa alexlapa marked this pull request as ready for review September 18, 2024 20:06
evdokimovs
evdokimovs reviewed Sep 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tyranron tyranron enabled auto-merge (squash) September 20, 2024 10:43
@tyranron tyranron enabled auto-merge (squash) September 20, 2024 10:44
@tyranron tyranron merged commit 39d7a12 into master Sep 20, 2024
50 checks passed
@tyranron tyranron deleted the migrate_wasm_to_talc branch September 20, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evdokimovs evdokimovs evdokimovs approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlapa @tyranron @evdokimovs